Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kubekins image to 1.24 #26678

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Update kubekins image to 1.24 #26678

merged 1 commit into from
Jun 27, 2022

Conversation

mkumatag
Copy link
Member

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2022
@mkumatag
Copy link
Member Author

/cc @Rajalakshmi-Girish @Amulyam24

@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2022
This was referenced Jun 27, 2022
Closed
Merged
@mkumatag
Copy link
Member Author

/retest-required

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2022
@mkumatag
Copy link
Member Author

@Amulyam24 fixed the review comment, ptal latest commit

Amulyam24
Amulyam24 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@Amulyam24 Amulyam24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rajalakshmi-Girish
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 7be3385 into kubernetes:master Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

@mkumatag: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key cluster-api-provider-ibmcom-periodics-main.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-periodics-main.yaml
  • key cluster-api-provider-ibmcom-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-ibmcloud/cluster-api-provider-ibmcom-presubmits.yaml

In response to this:

Fixes: kubernetes-sigs/cluster-api-provider-ibmcloud#666

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amulyam24 Amulyam24 Amulyam24 approved these changes

@gyliu513 gyliu513 Awaiting requested review from gyliu513

@jichenjc jichenjc Awaiting requested review from jichenjc

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

Assignees

@Amulyam24 Amulyam24

@Rajalakshmi-Girish Rajalakshmi-Girish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Adopt k8s 1.24
4 participants
@mkumatag @k8s-ci-robot @Rajalakshmi-Girish @Amulyam24